stop dropping ENTITY_REFERENCE events from text in XmlTokenStream - #901
Open
Sahana2524 wants to merge 1 commit into
Open
stop dropping ENTITY_REFERENCE events from text in XmlTokenStream#901Sahana2524 wants to merge 1 commit into
Sahana2524 wants to merge 1 commit into
Conversation
Member
|
entity references are really frowned on - turned out be a real security issue - so adding back support for them is probably not something that we would likely want to backport anything that gets added needs to be thoroughly tested to avoid reopening security attack vectors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the new
EntityReferenceReadTestagainst the unpatched tree:With a reader that has
IS_REPLACING_ENTITY_REFERENCESdisabled (Woodstox honors it, and the same goes for any reader handed tocreateParser(XMLStreamReader)),&e;inside element text arrives as anENTITY_REFERENCEevent, andXmlTokenStreamonly collectsCHARACTERS/CDATA, so the reference just vanished from the value with no error. Now it contributes the reader's replacement text, and fails with a locatedStreamReadExceptionwhen the reader has none (undeclared entity), which seemed better than a quietly truncated string. Default readers expand entities themselves and never produce these events, so nothing changes there. The same code is on 2.x and 3.1; happy to retarget if you would rather have it land there first.