Repository navigation
Make the editor's Lean helpers available to VIR - #11
Merged
FawadHa1der merged 1 commit intoNov 4, 2026
Merged
Conversation
Make get32, set32 and histAdd available as Lean definitions after ordinary imports so alternate backends can explicitly select their reference implementations. Preserve the existing inline C implementations. Co-Authored-By: Codex <noreply@openai.com>
ejgallego
changed the title
Owner
|
Thank you for the PRs @ejgallego |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The editor has three fast C helpers: one reads a pixel, one writes a pixel, and one updates a histogram. Each also has a Lean implementation.
VIR cannot use these C implementations. It needs the Lean versions, but those are currently hidden from files that import the editor. This adds
@[expose]to make the three Lean definitions available. Native and compiled Wasm builds keep using the existing C code.This prepares the helpers for VIR. Connecting the editor to VIR will be a separate change.
All 612 editor checks and 522 kit checks pass. A separate importing file can now access all three Lean definitions, and VIR can compile them as fallbacks.