Repository navigation
docs: show the tier names the CLI prints in the README images - #236
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#166 renamed the first tier from "Ready to clean" to "Eligible to clean", but the README's three images were captured before it and still show the old name, as do their alt text and the comment on
degu cleanin the lifecycle block. The images are rendered again from a real run of main at d1db13a, with the renderer #103 describes, on Linux and at the full fixture size, so the totals they show are unchanged. Besides the tier name, they now show what the scan and the review changed since: the line under the eligible heading, the reworded Not managed note, the numbered panels, the wider classification column and thet trashkey.In the list of what a preview reports before execution, "inventory ceilings" becomes "inventory bounds", since #227 and #228 retired the directory ceilings. The two checks added since, a source name too long for the trash (#232) and the room left in the seal WAL (#222, #223, #224), get a sentence of their own rather than joining that list: the preview blocks both, but staging measures both again against what the trash holds then, so it can still refuse an item the preview admitted. The user guide now says why for the name: the preview reads no trash and checks the name behind
0001-, while a clean checks it behind the sequence its reservation takes, which has five digits once the trash holds an entry numbered 9999.Rendering note. The review reads the account's readiness before it opens, so the account that renders it has to be set up with
degu initfirst. Without that, the header reads "Cleanup unavailable" instead of the plan total.Validation
Passed locally on this branch:
The README contract tests are at 6 passed / 0 failed. I compared the visible text of each new image with the committed one; the differences are the ones listed above, and the header still reads "In the plan: 2 locations · 9.33 GiB".