Repository navigation
refactor(loop): retire the lockstep training driver - #68
Merged
Merged
Conversation
…ire the lockstep driver Signed-off-by: Feathbow <feathbow@gmail.com>
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Shared training without
--stalenessstill used the lockstep driver, so it kept no journal and could not resume. Shared execution with explicit--staleness 0already used the event runtime. Make that path the default and remove the duplicate driver. Refs #26.What
Validation
Before removing the driver, the MLX test model trained the same two-cycle workload with the lockstep driver and with the runtime at staleness zero, with a shifted reference so that the policy changed in each update.
invar compare historiesfound the training log and the run directory equal, including the update schedule, and the published policy descriptions, adapters and learner checkpoints of both generations were byte-identical.The core suite, formatting, lint, type fixtures and the Hugging Face, MLX and shared worker suites passed on 614ab12. Disabling any of the runtime's shared checks, or either shared-owner invariant, made a test fail. The final removal of an unused forwarding helper and test reset code, plus the documentation clarification, received static review; the suites were not rerun after that cleanup.