Repository navigation
test(history): admit two-cycle, shared and learner-reference training logs and compare a log with a runtime run - #71
Merged
Merged
Conversation
… logs and compare a log with a runtime run Signed-off-by: Feathbow <feathbow@gmail.com>
… show a run comparison Signed-off-by: Feathbow <feathbow@gmail.com>
Signed-off-by: Feathbow <feathbow@gmail.com>
… two-cycle log with distinct generations Signed-off-by: Feathbow <feathbow@gmail.com>
…whose second cycle differs Signed-off-by: Feathbow <feathbow@gmail.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Training-log admission was tested on one cycle with engine reference scores only, and no test compared a training log with a runtime run over more than one update. The training driver that wrote these logs no longer exists, so a synchronous and a runtime execution cannot be produced side by side from this tree. Refs #30.
What
invar compare historiescompares the log with the run through the real codec. They are equal, including the update schedule, the learner state, gradients and probabilities of each generation, and the final inference. The two generations publish different adapters, so the comparison covers the policy sequence.invar compare historiescommand for two run directories and says where the final inference digests come from.Validation
The core suite, the Hugging Face worker suite, the type fixtures, formatting and lint pass. With the comparison of generation 2 replaced by a comparison of a generation with itself, the changed second cycle is reported as equal and the new test fails.