Repository navigation
Conversation
This was regressed by 26c0729 (Rasterize curves directly with trapezoids instead of flattening) Previously, curve_to_internal emitted the last flattened point with line_to_capped if the `end` parameter was true. The new curve_to_direct ignored its end argument and so wasn't capping when it should've. Instead of ignoring `end` cap if it's set. From https://bugzilla.mozilla.org/show_bug.cgi?id=2084919
This was regressed by 26c0729 (Rasterize curves directly with trapezoids instead of flattening) Previously, curve_to_internal stroked each flattened segment with line_to, which joined the segments. curve_to_direct instead draws trapezoids that share normals and doesn't join them. The outer edge of each trapezoid is a chord of the offset curve, so when a curve turns back on itself over a short distance the chord falls well inside the offset curve (about 5.5px for a 20px wide stroke in the bug) and the inner edge can cross itself. When the normal turns enough that the chord would fall more than half a pixel inside the offset curve, draw the segment as a rectangle with round joins at either end instead. From https://bugzilla.mozilla.org/show_bug.cgi?id=2084919
Collaborator
Author
|
@lsalzman Can you take a look at these fixes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fix the problems of https://bugzilla.mozilla.org/show_bug.cgi?id=2084919