Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #697
ROCm disk PLE currently uses
gatefallback. This PR adds HIP wait-sync and prevents deadlocks when submitting large graphs with wait-sync.It adds HIP signal memory, stream memops and capture probing (
autoprobes;waitrequires support). Use HIP signal memory for Engram's wait-sync flag.#697 uses early
cuGraphUploadto avoid the first-launch deadlock on CUDA. In our ROCm 10.1.0 large-graph checks,hipGraphUploadfollowed by stream synchronization did not prevent the deadlock. This may be related to the current HIP upload implementation:ihipGraphUploadreturns after handle validation and stream resolution, whilehipGraphUploadstill marks preparatory work as TODO. To avoid this deadlock, this PR starts a HIP-only CPU worker before replay to fill PLE rows and signal the flag independently of graph submission.CUDA's existing allocation, execution and synchronization logic is unchanged.
Validation
The baseline uses main's unchanged production code, with the new 16,384-kernel test included in the test suite.
Test files:
tests/kernels/test_row_store.pytests/models/qwen4_exp/test_ple_disk.pytests/models/deepseek_v41/test_engram.pyThe new regression and two existing Engram worker cases now run on ROCm.
Performance reference
Qwen/Qwen3.8-Flash-Next-FP8, 256 input / 128 output tokens, single GPU/request, MoE offload cache 1024, graph batch 1, ROCm 10.1.0. Compare main/gate, PR/gate and PR/wait under identical settings.
Each configuration was tested in two independent runs, with three measurements after warmup per run. The table reports the average of the two run medians.