Repository navigation
Conversation
Deploying fliplet-cli with
|
| Latest commit: |
bb1d357
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://767c18bb.fliplet-cli.pages.dev |
| Branch Preview URL: | https://feature-dev-2161-vue-runtime.fliplet-cli.pages.dev |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb1d357ab4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| path: route.path, | ||
| component: function() { | ||
| return Fliplet.Router.resolveRoute(route.path).then(function(result) { | ||
| return loadVueScreen(result.content); |
There was a problem hiding this comment.
When a protected route resolves with allowed: false because the user has no session or the media request returns 401/403, the result has no content; this passes undefined to loadVueScreen, causing an exception instead of navigating to result.redirectTo. Check result.allowed and redirect or return a placeholder component before parsing, as required by the Fliplet.Router.resolveRoute contract.
Useful? React with 👍 / 👎.
| ## What to fetch next | ||
|
|
||
| After picking, call `get_fliplet_docs('v3-framework-<name>')` for the specific constraints. Every per-framework doc covers: loading the framework, features that need a build step (and what to do instead), wiring to `Fliplet.Router`, binding `Fliplet.Media.authenticate`, common errors, and DO/DON'T. | ||
| After picking, fetch the matching guide with `fetch_fliplet_doc({ path: 'API/v3/frameworks/vue.md' })` (or the `react`, `alpine` or `vanilla` path) for its setup and constraints. Every per-framework doc covers: loading the framework, features that need a build step (and what to do instead), wiring to `Fliplet.Router`, binding `Fliplet.Media.authenticate`, common errors, and DO/DON'T. |
There was a problem hiding this comment.
Agents following this instruction cannot fetch the selected guide because both MCP implementations define fetch_fliplet_doc with a required url field containing a full https://developers.fliplet.com/...md URL; path is not accepted by the tool schema. Replace this example with the canonical URL argument so the documented follow-up call succeeds.
Useful? React with 👍 / 👎.
tonytlwu
changed the title
This branch has not been deployed
1 participant
Product areas affected
Developer documentation: V3 Vue and framework overview.
What does this PR do?
Corrects the false external SFC-loader prerequisite. Documents Fliplet.Media.parseSFC/evalModule, ordinary Vue screen blocks, runtime compiler loading and route integration; retains the existing generic asynchronous reactive-state example.
Tracked independently under DEV-2187 as framework documentation correctness. Replaces obsolete framework-document identifiers with canonical guide links and fetch paths. Studio PR #9017 requires this Vue contract before authoring asynchronous state.
JIRA ticket
DEV-2187
Result
Checklist
Deployment instructions
Normal CLI developer-doc publication after merge to master. Can publish before the companion Studio update. No runtime API change or migration.
Author concerns
The existing branch and commit names retain their original DEV-2161 prefix.
Jekyll emitted existing warnings in unrelated pages. The SDK fixture verifies parsing, module evaluation and Vue rendering, not authenticated media fetching or live customer-app navigation.