Skip to content

#6269 Sanitize srcset on images - #6273

Merged
sosnovsky merged 3 commits into
masterfrom
issue-6269-sanitize-srcset-on-images
Aug 11, 2026
Merged

#6269 Sanitize srcset on images#6273
sosnovsky merged 3 commits into
masterfrom
issue-6269-sanitize-srcset-on-images

Conversation

@martgil

@martgil martgil commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

This PR updates the forbidden css styles list to include srcset.

close #6269


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil
martgil requested a review from sosnovsky as a code owner August 10, 2026 05:45
@martgil
martgil marked this pull request as draft August 10, 2026 06:21
@martgil

This comment has been minimized.

@sosnovsky

Copy link
Copy Markdown
Collaborator

Hi @martgil, is this one ready for review or it's in progress?

@martgil
martgil marked this pull request as ready for review August 10, 2026 10:07
@martgil

This comment was marked as outdated.

Comment thread extension/js/common/platform/xss.ts
@martgil

martgil commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator Author

Hi @sosnovsky - This one is ready for a review again. Thanks!

@sosnovsky sosnovsky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now, thanks!

@sosnovsky
sosnovsky merged commit 9076886 into master Aug 11, 2026
12 checks passed
@sosnovsky
sosnovsky deleted the issue-6269-sanitize-srcset-on-images branch August 11, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sanitize srcset attribute on images

2 participants