Conversation
Vivitoto
force-pushed
the
feat/batch-gallery-actions
branch
from
September 10, 2026 04:20
dc39e07 to
8c19832
Compare
Collaborator
|
@Vivitoto Hi! Thanks for the PR, could you please split the torrent-related logic into a separate PR so we can review it first? The GalleryListScreen UI needs to be discussed, if we decided to add multi-selection, the long-press dialog would become unnecessary, should consider moving the "Read" button somewhere else. |
Vivitoto
force-pushed
the
feat/batch-gallery-actions
branch
from
September 10, 2026 05:13
8c19832 to
2516c52
Compare
Author
|
Thanks for the feedback. I split the torrent-related refactor into a separate smaller PR first: #3009. For this PR, I will keep the gallery-list multi-selection UI discussion separate and will not add more torrent behavior here. |
Vivitoto
force-pushed
the
feat/batch-gallery-actions
branch
from
September 10, 2026 10:01
2516c52 to
b2d3da6
Compare
Vivitoto
force-pushed
the
feat/batch-gallery-actions
branch
from
September 10, 2026 14:59
b2d3da6 to
99e790e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an opt-in batch selection mode to gallery lists.
It supports:
When multiple torrents are available for one gallery, the selected torrent can be chosen by:
The chosen magnet links are copied to the clipboard as newline-separated text.
Behavior
Existing gallery item behavior is preserved:
Batch mode is only enabled explicitly from:
In batch mode, tapping a gallery toggles its selected state.
UI
Batch mode uses the existing selectable item overlay style.
For gallery lists, the selection indicator reserves a stable top-right area while batch mode is active. Unselected items show an outline indicator, and selected items show a checked indicator. This avoids layout shifts and keeps long titles from colliding with the selected state indicator.
Notes
"Select all" only selects currently loaded paging items.
Batch favorite/unfavorite operations are processed sequentially to avoid firing many requests at once.
Test plan
Passed on fork CI:
CI run:
https://github.com/Vivitoto/EhViewer/actions/runs/34434538759
A pre-release APK build for manual testing is available here:
https://github.com/Vivitoto/EhViewer/releases/tag/batch-gallery-actions-3d07b1e