Repository navigation
fix: allow writes through shared table handles - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow writes through shared table handles
Related to #12.
Opening a table with
exclusive=falsecurrently selects a read-only filedescriptor (
r). A subsequenttableService.write()fails withEBADF, evenwhen the file is writable. Shared access and read-only access are separate concerns.
Attempt
r+for both modes and keep the existing fallback torwithwritable=falsewhen writable access is denied.Regression tests use temporary files and check exact bytes on disk for shared
and exclusive opens. A POSIX permissions test covers the read-only fallback.
The shared-write case fails with EBADF before this change and passes afterward.
Validation on macOS arm64:
This addresses a reproducible descriptor-level cause of EBADF. I have not
reproduced the full Windows INSERT scenario in #12 or its missing-fiber error.
This change does not implement shared-table locking; Windows runtime validation
and concurrency behavior remain separate checks.
Developed with AI assistance. Regression tests passed on macOS; the full Windows scenario remains unverified.