Repository navigation
fix: import bare Picture filenames as literal paths - #21
Merged
RandomChirp merged 1 commit intoOct 5, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import bare Picture filenames as literal paths
An SCX Properties memo can contain
Picture = sample.bmp. The importer currentlystores that filename in
meta.vfp.expressionsand leaves the Image's Pictureunset. At runtime the filename is evaluated as code instead of reaching the
image renderer as a path.
Recognize bare paths ending in common graphics extensions for registered Picture
properties. Preserve quoted literals and defer computed expressions as before.
A later literal Picture also clears an earlier deferred Picture expression.
The generic value parser and unrelated properties are unchanged.
Synthetic decoded SCX fixtures cover filenames, relative and absolute paths,
spaces, quoted values, expression cases and overrides. A runtime lifecycle test
checks that the imported filename is available without evaluating it as code.
Before the fix, four filename cases and the lifecycle case fail.
Validation on macOS arm64:
Rust was not rebuilt and Windows/VFP runtime validation was not performed.
This is deliberately bounded filename recognition, not a complete SCX expression
parser. Unquoted filenames containing expression punctuation and unsupported
extensions are outside this rule; quoted paths remain supported. Dotted names
can be ambiguous, so qualified built-in references and macro syntax are excluded.
This does not fix standalone-player asset roots, copy images into bundles, or
change Icon/DisabledPicture/DownPicture handling.
Developed with AI assistance; regression tests use synthetic fixtures only.