Skip to content

Add zizmor workflow for CI security checks - #551

Draft
Inverle wants to merge 1 commit into
FreshRSS:mainfrom
Inverle:add-zizmor-workflow
Draft

Inverle wants to merge 1 commit into
FreshRSS:mainfrom
Inverle:add-zizmor-workflow

Conversation

@Inverle

@Inverle Inverle commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Copied as is from https://github.com/FreshRSS/FreshRSS/blob/691616a6d0445839c95a41d1a8e20df015697ab6/.github/workflows/zizmor.yml with only the edge branch name changed to main.

Ideally we would follow https://docs.github.com/en/actions/how-tos/reuse-automations/reuse-workflows to avoid copying the workflows between repositories to keep them in sync, but that's for later.


TODO address zizmor findings:

Show findings
$ zizmor --persona=pedantic .github/workflows/*
 INFO zizmor: 🌈 zizmor v1.25.2
 INFO audit: zizmor: 🌈 completed .github/workflows/generate.yml
 INFO audit: zizmor: 🌈 completed .github/workflows/tests.yml
 INFO audit: zizmor: 🌈 completed .github/workflows/zizmor.yml
error[excessive-permissions]: overly broad permissions
 --> .github/workflows/generate.yml:9:3
  |
9 |   contents: write
  |   ^^^^^^^^^^^^^^^ contents: write is overly broad at the workflow level
  |
  = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> .github/workflows/generate.yml:19:15
   |
19 |         uses: actions/checkout@v7
   |               ^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

help[undocumented-permissions]: permissions without explanatory comments
 --> .github/workflows/generate.yml:9:3
  |
9 |   contents: write
  |   ^^^^^^^^^^^^^^^ needs an explanatory comment
  |
  = note: audit confidence → High

info[anonymous-definition]: workflow or action definition without a name
  --> .github/workflows/generate.yml:12:3
   |
12 |   build:
   |   ^^^^^ this job
   |
   = note: audit confidence → High
   = tip: use 'name: ...' to give this job a name

help[concurrency-limits]: insufficient job-level concurrency limits
  --> .github/workflows/generate.yml:3:1
   |
 3 | / on:
 4 | |   schedule:
 5 | |     - cron: '11 11 * * *'
 6 | |   workflow_dispatch: ~
   | |______________________^ workflow is missing concurrency setting
...
12 |     build:
   |     ----- job affected by missing workflow concurrency
   |
   = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> .github/workflows/tests.yml:23:13
   |
23 |       uses: actions/checkout@v7
   |             ^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> .github/workflows/tests.yml:38:13
   |
38 |       uses: actions/cache@v6
   |             ^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> .github/workflows/tests.yml:56:13
   |
56 |       uses: actions/checkout@v7
   |             ^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> .github/workflows/tests.yml:68:13
   |
68 |       uses: actions/setup-node@v7
   |             ^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> .github/workflows/tests.yml:93:13
   |
93 |       uses: actions/cache@v6
   |             ^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

info[anonymous-definition]: workflow or action definition without a name
  --> .github/workflows/tests.yml:14:3
   |
14 |   tests:
   |   ^^^^^ this job
   |
   = note: audit confidence → High
   = tip: use 'name: ...' to give this job a name

help[concurrency-limits]: insufficient job-level concurrency limits
  --> .github/workflows/tests.yml:3:1
   |
 3 | / on:
 4 | |   push:
 5 | |     branches: [ main ]
 6 | |   pull_request:
 7 | |     branches: [ main ]
   | |______________________^ workflow is missing concurrency setting
...
14 |     tests:
   |     ----- job affected by missing workflow concurrency
   |
   = note: audit confidence → High

13 findings (1 ignored): 2 informational, 3 low, 0 medium, 7 high

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants