Skip to content

fix heap overflow in SfxEntry::add when strip exceeds word length #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arshsmith1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix heap overflow in SfxEntry::add when strip exceeds word length #687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/speller/default/affix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1196,6 +1196,10 @@ SimpleString SfxEntry::add(SimpleString word, ObjStack & buf,
break;
}
if (cond < 0) {
// conditions are checked against orig_word, but the suffix is
// stripped from word, which may be shorter (e.g. after a
// cross-product prefix). Bail if it can't hold the strip.
if (word.size <= stripl) return SimpleString();
int alen = word.size - stripl;
if (alen >= limit) return EMPTY;
/* we have a match so add suffix */
Expand Down