Repository navigation
fix(telemetry-receiver): dashboard ranges end on today - #631
Merged
Merged
Conversation
The dashboard built every view up to yesterday, the latest complete UTC day, so a new provider saw "No reports yet" for up to a day after its first accepted report, and today's reports never showed until the day closed. Ruled as OD-6 (2026-10-08): the dashboard shows all data. - views.go: asOf is today (UTC, in progress); every range ends on it. Today's lapsed-installs value stays 0 until the lifecycle job finalises the day. /v1/summary and the lifecycle rollover are unchanged. - Copy (designed first in telemetry-dashboard.pen i0xK1E, Z079vK, y49Ie, exported): "Data through ... (UTC, today in progress)", "Reports, today", "Active installs, today", a new empty-state text, the reports-per-day caption and the lapsed note. - Tests (signed off 2026-10-08): the views, dashboard and population test clocks move back one day so every assertion is unchanged; new TestBuildViewsIncludesTodayInProgress; the e2e dashboard check expects asOf = today. - Spec 022: data-model, spec, receiver-http contract, tasks (superseded notes) and OD-6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019f17vxYJKVGNFSgucHnuhu Signed-off-by: valgulnecron <39313199+ValgulNecron@users.noreply.github.com>
ValgulNecron
added
area: e2e
Brings in the spec 022 archive (#624). Git's rename detection carries this branch's OD-6 edits to specs/done_022-default-telemetry-dashboard/; GitHub's mergeability check did not detect the rename and reported a conflict. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019f17vxYJKVGNFSgucHnuhu Signed-off-by: valgulnecron <39313199+ValgulNecron@users.noreply.github.com>
CI Report - 93d15acrun 37784923057 - attempt 1 0 failed - 18 passed - 7 skipped - 40m27s elapsed Coverageno coverage/* commit statuses found on 93d15ac Changed
Slowest jobs
e2e buckets run
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The receiver dashboard built every view up to yesterday (the latest complete UTC day). A new provider saw "No reports yet" for up to a day after its first accepted report, and today's reports never showed until the day closed. Ruled as OD-6 (2026-10-08): the dashboard shows all data.
telemetry-receiver/views.go:asOfis today (UTC, in progress), and every 7/30/90/365-day range ends on it. The empty state appears only when the range has no report at all. Today's lapsed-installs value stays0until the lifecycle job finalises the day.GET /v1/summary(still the latest complete day) and the lifecycle rollover.telemetry-dashboard.pen(i0xK1E,Z079vK,y49Ie) and exported (JSON checked equal to Pencil by length + FNV-1a hash, PNGs at 2x):specs/done_022-…):data-model.md,spec.mdandcontracts/receiver-http.mdupdated;tasks.mdT065/T071 get "superseded" notes; OD-6 added toOPEN-DECISIONS.md.Test sign-offs (system override 1)
Signed off 2026-10-08 ("Approve test updates", "Approve e2e change"):
views_test.go,dashboard_test.go,population_test.go: the fixed clocks move back one day, so every assertion and expected date is unchanged.charts_test.go: comment only.TestBuildViewsIncludesTodayInProgress: a report accepted today is the lastreportsPerDayentry, leaves the empty state, and its totals are the latest-day row.test/e2e/telemetry_e2e_test.godashboard_shows_reports: expectsasOf= today instead of yesterday (same check).requireViewsUnchangedis unchanged, because same-day reports from the install are duplicates and don't change the views.Test plan
go build ./...(telemetry-receiver), type check including_test.gofiles (telemetry-receiver, test/e2e withe2etag), gofmt cleanNote: master (with the #624 archive) is merged in, so the spec edits now live in
specs/done_022-default-telemetry-dashboard/.🤖 Generated with Claude Code
https://claude.ai/code/session_019f17vxYJKVGNFSgucHnuhu