Repository navigation
feat(containers): build fivem, beammp, fs25 and ets2 images here - #651
Merged
Merged
Conversation
Move the four Gameplane-owned image sources unchanged from the module repo into containers/games/ and add them to the images.yaml matrix, so merging publishes and cosign-signs them to ghcr.io/gameplanepanel/gameplane like the SteamCMD games. The module repo's build-images workflow had no signing key and never pushed them (maintainer ruling 2026-10-10, OPEN-DECISIONS §10). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
ValgulNecron
added
area: modules
Claude
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CI Report - f566fccrun 38095839471 - attempt 1 0 failed - 20 passed - 6 skipped - 31m11s elapsed Coverageno coverage/* commit statuses found on f566fcc Changed
Slowest jobs
e2e buckets run
|
ValgulNecron
marked this pull request as ready for review
October 11, 2026 02:16
ValgulNecron
pushed a commit
to GameplanePanel/module
that referenced
this pull request
Oct 11, 2026
Replace the placeholder digest with the real one for the four images published and cosign-signed by GameplanePanel/Gameplane#651 (T141). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the FiveM, BeamMP, Farming Simulator 25 and Euro Truck Simulator 2 images were built by the module repo's
build-images.yml, which has no signing key, so it only built them and never pushed. Their module templates point at images that don't exist.After: their Dockerfiles and entrypoints live in
containers/games/<game>/and are part of theimages.yamlmatrix. Merging publishes and cosign-signs them toghcr.io/gameplanepanel/gameplane/<game>, the same way #638 did for the SteamCMD games.How: the files are copied over unchanged. These four don't build on the SteamCMD base, so they ignore the
STEAMCMD_BASE_IMAGEbuild arg;containers/README.mdnotes this.OPEN-DECISIONS.md§10 records the 2026-10-10 maintainer ruling. GameplanePanel/module#48 removes the old copies and will pin the digests once this merges (spec 015, T141).🤖 Generated with Claude Code
Generated by Claude Code