Repository navigation
fix(modules): bump modules for spec 015 image pins and close Phase 9 docs - #653
Merged
Merged
Conversation
…docs Bump the modules submodule to GameplanePanel/module#48 (real digests for nine of the ten placeholder templates). Re-read engine-matrix-resolved.md from the shipped templates and buckets.sh (T143), mark plan.md Known Gaps 1-4 resolved and update research.md's shipped state (T144), and mark T141-T146 done. hell-let-loose stays open pending its image ruling (T133/T138). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
ValgulNecron
added
area: modules
Claude
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CI Report - b6fdd7crun 38108848742 - attempt 1 0 failed - 19 passed - 7 skipped - 37m6s elapsed Coverageno coverage/* commit statuses found on b6fdd7c Changed
Slowest jobs
e2e buckets run
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the
modulessubmodule points at a revision where ten new templates use never-published images with placeholdersha256:000…digests, and the 015 spec docs (engine matrix, plan Known Gaps, research shipped state) describe that broken state.After:
modulespoints at GameplanePanel/module#48, so nine of those templates run real, digest-pinned images (eight Gameplane-built fromcontainers/games/, plus the ACE Arma Reforger image). The spec docs match what shipped.How:
engine-matrix-resolved.md: protocol,consoleMode, ports, mount path, stop and CI bucket re-read from the shippedtemplate.yamlfiles andtest/e2e/buckets.sh(T143). All 13 new modules are inbucket_bot_heavy.plan.mdKnown Gaps 1-4 marked resolved with task citations, and research.md Decision 1's shipped state updated (T144).tasks.md: T141-T146 marked done. Hell Let Loose stays open (T133/T138) until its image ruling.🤖 Generated with Claude Code
Generated by Claude Code