Skip to content

chore: remove Hell Let Loose and point hand-run spec 015 tests at shipped images - #657

Merged
ValgulNecron merged 3 commits into
masterfrom
claude/project-thread-e1071w
Oct 11, 2026
Merged

chore: remove Hell Let Loose and point hand-run spec 015 tests at shipped images#657
ValgulNecron merged 3 commits into
masterfrom
claude/project-thread-e1071w

Conversation

@ValgulNecron

@ValgulNecron ValgulNecron commented Oct 11, 2026

Copy link
Copy Markdown
Collaborator

Before: seven hand-run bot-heavy e2e tests still used placeholder digests and old mount paths. Hell Let Loose had a test, a probe package and spec entries for a module that cannot get an image.

After: the seven tests (Squad bot and RCON, The Isle, ARK: Survival Evolved bot and cluster persistence, Bannerlord, Arma Reforger) use the published images and their real layout. Gameplane-built images use /data and UID 10000; Arma uses the ACE image under /reforger. Hell Let Loose is removed from e2e, the docs and spec 015.

The maintainer approved both changes on 2026-10-11:

  • update the seven tests;
  • remove the module and delete its test (OPEN-DECISIONS §10).

How:

  • Commit 1 repoints the seven tests.
  • Commit 2 deletes hellletloose_bot_e2e_test.go and internal/hell-let-loose/, and drops HLL from bucket_bot_heavy and heavyGameSet. It also removes HLL from docs/game-coverage.md and docs/module-authoring.md, updates the README counts and adds an Unreleased "Removed" note.
  • Spec 015: commit 2 records the ruling in OPEN-DECISIONS §10, spec.md, plan.md, research.md and the engine matrices. It marks T133/T138 withdrawn and T147 done.
  • Still to do: the modules pointer bump follows once chore: remove the hell-let-loose module module#49 merges.

🤖 Generated with Claude Code

Generated by Claude Code

claude added 2 commits October 11, 2026 17:22
@claude
test(e2e): point seven hand-run spec 015 tests at the shipped images
1cf0914 
Squad, The Isle, ARK SE and Bannerlord now use the Gameplane-built images (UID 10000, whole install on /data) and Arma Reforger the ACE image (/reforger, GAME_NAME). Update the image digests, mount paths, env keys and security values these hand-run tests use to match the shipped templates; no assertions change. Maintainer sign-off 2026-10-11.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@claude
chore: remove Hell Let Loose from e2e, docs and spec 015
1815fa3 
The maintainer withdrew the hell-let-loose module on 2026-10-11: its
server files go only to Team17's licensed hosting partners, so no image
can install it. Delete its hand-run e2e test and probe package, drop it
from bucket_bot_heavy and heavyGameSet, remove it from the coverage and
authoring docs, add an Unreleased Removed note, and record the ruling in
spec 015 (OPEN-DECISIONS §10, T133/T138 withdrawn, T147 done).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@ValgulNecron ValgulNecron added area: e2e kind-based end-to-end suite area: modules game template OCI bundles area: specs spec-kit feature specs and design docs type: chore Maintenance, deps, or housekeeping type: test Test additions or changes labels Oct 11, 2026 — with Claude
@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 30 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: GameplanePanel/Gameplane/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 033d0f77-4ec2-499b-ac04-56602cf65015
📥 Commits

Reviewing files that changed from the base of the PR and between 5c005d2 and 7ed254e.

📒 Files selected for processing (26)
  • CHANGELOG.md
  • README.md
  • docs/game-coverage.md
  • docs/module-authoring.md
  • modules
  • specs/015-top-steam-game-modules/OPEN-DECISIONS.md
  • specs/015-top-steam-game-modules/contracts/engine-matrix-contract.md
  • specs/015-top-steam-game-modules/engine-matrix-resolved.md
  • specs/015-top-steam-game-modules/plan.md
  • specs/015-top-steam-game-modules/research.md
  • specs/015-top-steam-game-modules/spec.md
  • specs/015-top-steam-game-modules/tasks.md
  • test/e2e/arksurvival_cluster_persistence_e2e_test.go
  • test/e2e/arksurvivalevolved_bot_e2e_test.go
  • test/e2e/armareforger_bot_e2e_test.go
  • test/e2e/buckets.sh
  • test/e2e/gamebot_helpers_e2e_test.go
  • test/e2e/hellletloose_bot_e2e_test.go
  • test/e2e/internal/hell-let-loose/app.go
  • test/e2e/internal/hell-let-loose/spec.md
  • test/e2e/internal/specs.md
  • test/e2e/mountandblade2bannerlord_bot_e2e_test.go
  • test/e2e/squad_bot_e2e_test.go
  • test/e2e/squad_rcon_e2e_test.go
  • test/e2e/theisle_bot_e2e_test.go
  • website
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ValgulNecron ValgulNecron self-assigned this Oct 11, 2026
@ValgulNecron Claude

ValgulNecron commented Oct 11, 2026

Copy link
Copy Markdown
Collaborator Author

e2e bucket coverage is red at joincoverage.sh verify, with module 'hell-let-loose' found in modules/ but not listed in docs/game-coverage.md. This PR removes HLL from the coverage doc, but the modules submodule pointer still includes the module.

The fix is the pointer bump to GameplanePanel/module#49, which deletes hell-let-loose/. The repo convention is to bump submodule pointers only after the submodule PR merges, so I'll push that bump here as soon as module#49 merges. That push should turn this check green. Until then, this check stays red.

Generated by Claude Code

@claude
chore: bump modules and website pointers after Hell Let Loose removal
7ed254e 
modules: GameplanePanel/module#49 (hell-let-loose removed).
website: GameplanePanel/website#15 and #16 (module count text).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown

CI Report - 7ed254e

run 38160514819 - attempt 1

0 failed - 25 passed - 1 skipped - 30m35s elapsed

Coverage

Module Measured Gate Margin
web L95.48 S93.97 B88.66 F91.78 L92 S92 B82 F76 +1.97

Changed

Area Files +/-
test/ 13 +23/-223
specs/ 7 +19/-21
(root) 4 +11/-4
docs/ 2 +1/-3

Slowest jobs

Job Duration
e2e telemetry / amd64 (kind) 23m22s
e2e telemetry / arm64 (kind) 22m28s
e2e capture overhead (kind) 13m55s
e2e game bot / TestGameServer_GarrysModBot_Query (kind) 9m30s
e2e multicluster / amd64 (kind x2) 9m26s

e2e buckets run

api-agent, api-auth, api-mods, api-rbac, api-roles, bot-fast, multicluster, operator, ratelimit, telemetry, upgrade

@ValgulNecron
ValgulNecron merged commit b9596f2 into master Oct 11, 2026
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ValgulNecron ValgulNecron

Labels

area: e2e kind-based end-to-end suite area: modules game template OCI bundles area: specs spec-kit feature specs and design docs type: chore Maintenance, deps, or housekeeping type: test Test additions or changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ValgulNecron @claude