Skip to content

fix(web): remove doubled spacing in admin auth cards #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ValgulNecron merged 2 commits into from
Oct 14, 2026
Merged

fix(web): remove doubled spacing in admin auth cards #698

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e29567
fix(web): remove doubled spacing in admin auth cards
claude Oct 14, 2026
9059cdf
fix(web): tighten admin page header gap and Helm OIDC rows
claude Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions web/src/routes/AdminSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export function AdminSettingsPage() {
};

return (
<div className="space-y-6 p-6">
<div className="space-y-4 p-6">
<PageHeader
title="Admin settings"
description="Platform-wide configuration for this Gameplane instance."
Expand Down Expand Up @@ -474,7 +474,7 @@ function AuthSection({ initial, general, installTimeSettings }: { initial?: Auth
return (
<div className="space-y-6">
<SectionCard
className="gap-0 p-0"
className="gap-0 space-y-0 p-0"
title="Authentication"
subtitle="Built-in local accounts plus federated identity providers. Changes take effect on save — no restart needed."
titleClassName="text-sm font-medium"
Expand Down Expand Up @@ -551,7 +551,7 @@ function AuthSection({ initial, general, installTimeSettings }: { initial?: Auth
)}
</ul>
{lastToggleLocked && (
<p className="mt-4 text-xs text-muted">
<p className="text-xs text-muted">
At least one identity provider must stay enabled — the last enabled
provider can&apos;t be turned off.
</p>
Expand Down Expand Up @@ -1981,16 +1981,16 @@ function HelmOIDCProviderCard({ provider }: { provider: OIDCHelmProvider }) {
const adminMapped = provider.roleMappings?.admin && provider.roleMappings.admin.length > 0;
return (
<SectionCard
className="gap-0 p-0"
className="gap-0 space-y-0 p-0"
title="Helm-seeded OIDC provider"
subtitle="Read-only snapshot of the identity provider configured via api.oidc.* Helm values at install time. Connection settings are not editable here; role mappings can be overridden below."
titleClassName="text-sm font-medium"
subtitleClassName="text-sm"
headerClassName="px-5 pt-5 pb-4 space-y-1"
contentClassName="px-5 pb-5 space-y-4"
>
<div className="space-y-4">
<div className="space-y-2">
<div>
<div className="space-y-0.5 pb-1">
<div className="font-medium text-sm">Provider</div>
<p className="text-[11px] text-muted">
Groups claim and default role are seeded from the same Helm values and are not editable here.
Expand Down Expand Up @@ -2049,7 +2049,7 @@ function HelmOIDCProviderCard({ provider }: { provider: OIDCHelmProvider }) {
</div>
)}
{adminMapped && (
<div className="rounded-lg border border-warning-soft-foreground bg-warning-soft px-4 py-3 flex gap-4">
<div className="mt-3 rounded-lg border border-warning-soft-foreground bg-warning-soft px-4 py-3 flex gap-4">
<Megaphone className="h-4 w-4 text-warning-soft-foreground flex-shrink-0 mt-0.5" />
<div className="text-sm">
<div className="font-medium text-warning-soft-foreground mb-1">Helm-configured admin mapping</div>
Expand Down Expand Up @@ -2199,7 +2199,7 @@ function RoleMappingOverridesCard({
<SectionCard
title="Role mapping overrides"
subtitle="Override the Helm-seeded OIDC group mappings per role from here. A change takes effect the next time an affected user logs in — no restart or reinstall needed."
className="bg-card gap-0 p-0"
className="bg-card gap-0 space-y-0 p-0"
titleClassName="text-sm font-medium"
subtitleClassName="text-sm"
headerClassName="px-5 pt-5 pb-4 space-y-1"
Expand Down Expand Up @@ -2247,7 +2247,7 @@ function RoleMappingOverridesCard({

return (
<div key={role} role="group" aria-label={`${role.charAt(0).toUpperCase() + role.slice(1)} role mapping`}>
{role !== "admin" && <div className="h-px bg-border" />}
{role !== "admin" && <div className="mb-4 h-px bg-border" />}
<div className="space-y-2">
<div className="flex items-center justify-between">
<div className="flex items-center gap-2">
Expand Down
Loading