Skip to content

fix: respect addon-number ordering for community patch BIG loading - #547

Open
tintinhamans wants to merge 1 commit into
GeneralsOnlineDevelopmentTeam:mainfrom
tintinhamans:arctic/go-patch-08
Open

fix: respect addon-number ordering for community patch BIG loading#547
tintinhamans wants to merge 1 commit into
GeneralsOnlineDevelopmentTeam:mainfrom
tintinhamans:arctic/go-patch-08

Conversation

@tintinhamans

Copy link
Copy Markdown

Summary

This change makes the community patch BIG load in a way that respects the same ordering conventions as other addon BIGs in the game folder.

What changed

  • Added a sortedByName mode to ArchiveFileSystem::loadIntoDirectoryTree so duplicate files can be inserted according to archive filename order rather than always overwriting or appending blindly.
  • Refactored community patch loading to open the patch BIG directly from the user data directory and merge it into the archive tree using that sorted ordering.
  • Initialized NGMP settings earlier in game startup so DataPacks_UseCommunityPatch is available before loadMods() runs.

Why

Community patch content should behave like other addons in the game folder, where lower-numbered addon archives generally take precedence over higher-numbered ones. This makes the patch integrate more predictably alongside other installed mods and add-ons.

Notes

This keeps the community patch from being treated as a flat override and instead allows it to participate in the same load-order semantics as other BIG files.

…ryTree and refactor community patch loading logic

Signed-off-by: tintinhamans <5984296+tintinhamans@users.noreply.github.com>

@Mauller Mauller left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any major issues, looks okay overall to me

@tintinhamans tintinhamans changed the title Respect addon-number ordering for community patch BIG loading fix: respect addon-number ordering for community patch BIG loading Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

⚠️ Title/Commit Validation Failed

Invalid PR title:

  • fix: respect addon-number ordering for community patch BIG loading

Invalid commit messages:

  • Enhance ArchiveFileSystem: Add sortedByName option to loadIntoDirectoryTree and refactor community patch loading logic
    PR titles and commit messages must follow conventional commits format:
type: Description
type(scope): Description

Allowed types: bugfix, build, chore, ci, docs, fix, feat, perf, refactor, revert, style, test, tweak, unify

See CONTRIBUTING.md for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants