build: begin migration to Typescript - #251
Draft
Tomahawk2191 wants to merge 2 commits into
Draft
Conversation
Contributor
👷 Deploy Preview for sprightly-manatee-243873 processing.
|
Tomahawk2191
changed the base branch from
isaac/migrate-to-oxlint-oxfmt
to
isaac/migrate-to-vite
September 5, 2026 20:11
Tomahawk2191
force-pushed
the
isaac/migrate-to-ts
branch
from
September 5, 2026 20:11
c07f463 to
6a699e5
Compare
Tomahawk2191
force-pushed
the
isaac/migrate-to-ts
branch
from
September 6, 2026 18:40
6a699e5 to
3656b29
Compare
Tomahawk2191
changed the base branch from
isaac/migrate-to-vite
to
isaac/update-sanity-config
September 6, 2026 18:44
Tomahawk2191
force-pushed
the
isaac/migrate-to-ts
branch
from
September 6, 2026 19:32
3656b29 to
4998f5a
Compare
Tomahawk2191
force-pushed
the
isaac/migrate-to-ts
branch
from
September 10, 2026 22:19
4998f5a to
63c8422
Compare
Tomahawk2191
force-pushed
the
isaac/migrate-to-ts
branch
from
September 11, 2026 01:10
63c8422 to
4bd23b3
Compare
Tomahawk2191
force-pushed
the
isaac/migrate-to-ts
branch
2 times, most recently
from
September 11, 2026 01:14
549f1c2 to
96c2341
Compare
useLocation was referenced but never invoked, and the destructured key was pathName rather than pathname. The effect dependency was therefore always undefined and the scroll reset never fired on navigation.
Tomahawk2191
force-pushed
the
isaac/migrate-to-ts
branch
from
September 12, 2026 19:16
96c2341 to
beedf5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did I do?
Migrating the project from Javascript to Typescript.
How did I test it?
Describe in detail steps you used to test the changes you have made.
Required checks:
What could go wrong in the future? What parts of your code should the reviewer pay the most attention to?
Describe aspects of the PR that may become problems in the future.
Additional Comments for the Reviewers
Screenshots
FIGMA
MY VERSION
Stack created with GitHub Stacks CLI • Give Feedback 💬