ROS: rename package to example_robot_descriptions - #388
Merged
Merged
Conversation
I tried to add this projet to ROS buildfarm, so that tsid/crocoddyl/HPP/mim_solvers/ndcurves/etc. can more easily use `<test_depend>example_robot_data</test_depend>` in their `package.xml` ROS PMC is OK with that, but believe the name would not be suitable, and did propose `example_robot_descriptions` instead. I think this name is good, and I don't think changing **only the ROS name** is too big of an issue. This commit is doing that, only in our `package.xml`, so this will have to be adaptated in the `package.xml` of dependent packages. cc @MaximilienNaveau, at least, about this Just to be clear, I don't intend to rename github name/url, cmake project, c++ header dir, python module, and packages in AUR, conda, PyPI, nixpkgs, etc. at least until we get a lot of feedback and a very good consensus. ref. ros/rosdistro#53263 ref. Gepetto#1
Collaborator
|
Hi @nim65s In my opinion, the name example-robot-data is quite misleading. This is why I support replacing it with example-robot-descriptions broadly (i.e., github name/url, cmake project, C++ header, etc.). I'm not sure what the right transition action is, but it seems a justified action. |
Member
Author
|
Ok, thanks for your opinion, I'll keep discuss this with more people, and if nobody raise more objections I'll start working on a bigger migration plan |
nim65s
added a commit
to nim65s/aig
that referenced
this pull request
Sep 28, 2026
This was referenced Sep 28, 2026
nim65s
added a commit
to Gepetto/biped-stabilizer
that referenced
this pull request
Sep 28, 2026
This was referenced Sep 28, 2026
nim65s
added a commit
to humanoid-path-planner/hpp-baxter
that referenced
this pull request
Sep 28, 2026
nim65s
added a commit
to humanoid-path-planner/hpp-environments
that referenced
this pull request
Sep 28, 2026
nim65s
added a commit
to humanoid-path-planner/hpp-universal-robot
that referenced
this pull request
Sep 28, 2026
nim65s
added a commit
to nim65s/mim_solvers
that referenced
this pull request
Sep 28, 2026
nim65s
added a commit
to humanoid-path-planner/hpp-romeo
that referenced
this pull request
Sep 28, 2026
nim65s
added a commit
to humanoid-path-planner/hpp-pinocchio
that referenced
this pull request
Sep 28, 2026
nim65s
added a commit
to humanoid-path-planner/hpp-constraints
that referenced
this pull request
Sep 28, 2026
nim65s
added a commit
to humanoid-path-planner/hpp-core
that referenced
this pull request
Sep 28, 2026
nim65s
added a commit
to humanoid-path-planner/hpp-manipulation
that referenced
this pull request
Sep 28, 2026
nim65s
added a commit
to humanoid-path-planner/hpp-manipulation-urdf
that referenced
this pull request
Sep 28, 2026
nim65s
added a commit
to humanoid-path-planner/hpp-tutorial
that referenced
this pull request
Sep 29, 2026
nim65s
added a commit
to loco-3d/crocoddyl
that referenced
this pull request
Sep 29, 2026
nim65s
added a commit
to nim65s/linear-feedback-controller
that referenced
this pull request
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I tried to add this projet to ROS buildfarm, so that tsid/crocoddyl/HPP/mim_solvers/ndcurves/etc. can more easily use
<test_depend>example_robot_data</test_depend>in theirpackage.xml.ROS PMC is OK with that, but believe the name would not be suitable for ROS, and did propose
example_robot_descriptionsinstead.I think this name is good, and I don't think changing only the ROS name is too big of an issue.
This commit is doing that, only in our
package.xml, so this will have to be adaptated in thepackage.xmlof dependent packages. On this topic, this is a breaking change.cc. @cmastalli & @MaximilienNaveau about this.
Just to be clear, I don't intend to rename github name/url, cmake project, c++ header dir, python module, and packages in AUR, conda, PyPI, nixpkgs, etc. at least until we get a lot of feedback and a very good consensus.
ref. ros/rosdistro#53263
ref. #1