Fix HTTP body editing after deleting the selected node - #851
Merged
Merged
Conversation
Removing the selected body node or an ancestor left the next edit using deleted storage. Move the selection to its surviving parent and cover continued editing with command-level sanitizer tests.
Collaborator
|
@barryw Thanks for spotting this. Could you please analyze which actual user facing features are degraded by this bug so we can triage it for 3.15? |
Contributor
Author
|
@chrisgleissner this can go with 3.16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting the selected HTTP body object, or its ancestor, leaves the next edit using freed storage. Keep the editing position at the surviving parent in
HttpBodySlot::remove. Tests cover deleting the selection, an ancestor, an unrelated sibling and an array element.Introduced after 3.14 with the HTTP target. Tested independently against
test-mergeat8596576f, in the upstream pipeline’smy_docker_image(host G++ 13.3.0):Same tests, changing only the firmware fix:
Red/green evidence; final CI build passed all five firmware targets and the application-space gate. The test target loads ASan before the CI image’s preloaded libraries. Hardware E2E was not run.