Skip to content

temporarily disable plot annotations in vignettes and unit test function - #589

Closed
cying111 wants to merge 1 commit into
develfrom
plotBambu_fix
Closed

cying111 wants to merge 1 commit into
develfrom
plotBambu_fix

Conversation

@cying111

@cying111 cying111 commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Related Issue

Bioconductor build error

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (please specify if the change breaks existing functionality)
    • Non breaking change (the feature doesn't change existing functionality)
    • Breaking change (the feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance optimization

Description

ggbio autoplot for plotting annotations is not working properly and that has caused issues in Bioconductor build error. I have temporarily disabled the section related to using ggbio for plotting annotations in both vignettes and unit test function. If this issue persists long time, for next release, should consider to replace ggbio with another package.

Implementation Details

2 changes are made.

  • first change is inside vignettes bambu.Rmd, disabled section from line 238 to line 240.
  • second change is at test_plotBambu function, all test lines using ggbio plotting functions are commented out

Impact of Changes

  • Results are identical to the previous version.
  • visualization for annotations is no longer working properly

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have verified that GitHub automated tests passed. (Describe any failing tests in the next section)
  • [] I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (vignettes, man pages).
  • I have tested the code on a full dataset, and any differences have been described in the pull request.

Post-merge follow-up

  • plotBambu function not working properly for plot annotations, consider to submit proper fix later

@cying111 cying111 closed this Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants