Repository navigation
Conversation
…ustom.regex group
There was a problem hiding this comment.
Code Review
This pull request updates the Renovate configuration in .github/renovate.json by setting semantic commit types for Go module and custom regex dependencies, and renaming dependency groups to include 'tooling'. A review comment points out that setting semanticCommitType to 'fix' on the general gomod manager rule will cascade to Go version updates, potentially triggering unnecessary production releases. It is recommended to explicitly override this to 'chore' for Go version updates.
| "matchManagers": [ | ||
| "gomod" | ||
| ], | ||
| "semanticCommitType": "fix", |
There was a problem hiding this comment.
Setting "semanticCommitType": "fix" on the general gomod manager rule will also cascade to the subsequent golang-version rule (lines 83-92), which matches the gomod manager and golang-version datasource.
Since Go toolchain/version updates are typically considered maintenance or toolchain updates (chore) rather than bug fixes (fix), they might trigger unnecessary production releases if they use semantic-release or similar tools.
Consider explicitly overriding "semanticCommitType": "chore" in the golang-version rule to keep Go version updates as chore.
There was a problem hiding this comment.
Intentionally keeping golang-version updates as fix(deps):. Both go / toolchain directive updates and module require updates touch the same go.mod file and are grouped together in the {{packageFileDir}} deps PR, and bumping the go directive in go.mod updates the published module metadata and the Go toolchain (go-version-file) used to build released binaries.
Summary
"semanticCommitType": "fix"forgomodupdates: Configure Go module dependency updates across CFT's releasable Go tools (cli,tflint-ruleset-blueprint,infra/blueprint-test,infra/module-swapper, andinfra/utils/fbf) to usefix(deps):instead ofchore(deps):for both standard dependency updates and vulnerability alert PRs.custom.regex(Makefileandbuild/*.cloudbuild*.yaml) into its ownchore(deps):group: Set"semanticCommitType": "chore",groupName: "{{#if packageFileDir}}{{{packageFileDir}}} tooling deps{{else}}root tooling deps{{/if}}", andgroupSlug: "{{#if packageFileDir}}{{{replace '/' '-' packageFileDir}}}-tooling-deps{{else}}root-tooling-deps{{/if}}"oncustom.regexmanagers soMakefileand Cloud Build tooling updates (cft/developer-tools,golangci-lint,alpine) remainchore(deps):and do not merge intogo.modPRs incli/orinfra/blueprint-test/.