Repository navigation
fix: semver sorting for kernel packages - #52
Merged
m-strzelczyk merged 2 commits intoSep 22, 2026
Merged
Conversation
Contributor
Author
|
See #53 |
Contributor
Author
|
You might also consider letting self.run("apt-get install -y make gcc linux-image-cloud-amd64 "
"linux-headers-cloud-amd64 pciutils gcc make dkms cmake git")I'm assuming there's a good reason for parsing version numbers explicitly, but it might be better to let |
Collaborator
|
Hey @barabo ! I remember that I had a good reason to not let APT figure out the versions and I think the answer lies with the comment: I remember there were some weird dependency or header related issues when the script jumped to a major new kernel version. Thanks for the PR, I'll run some tests and get it merged ASAP :) |
The tool is required to run on Python 3.6 (that's the version installed by default on Rocky 8 and RHEL 8), so I had to modify the type hints a bit.
m-strzelczyk
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current Debian installer does not sort kernel version numbers using semver, so when the headers version jumped from
96to105- the wrong version is selected.This change creates a comparator that respects both ABI and kernel version numbers numerically.