Skip to content

test(mdcode): expect the translated metric as a BIGQUERY dialect entry in the two-phase transpile test #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feixufeixu merged 1 commit into from
Oct 24, 2026
Merged

test(mdcode): expect the translated metric as a BIGQUERY dialect entry in the two-phase transpile test #562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion toolbox/mdcode/tests/tool/two_phase/deploy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,8 @@ scenarios('how push deploys each deployment in order, and what it prints', [
check: r => {
for (const models of [...r.fake.bq.mock.calls.map(c => c[0]),
r.fake.preflight.mock.calls[0][0]]) {
expect(models[0].model.metrics?.[0]?.expression).toBeDefined();
expect(models[0].model.metrics![0].dialects)
.toContainEqual(expect.objectContaining({dialect: 'BIGQUERY'}));
}
},
},
Expand Down
Loading