Conversation
Wrap each annotation separately and retain its indentation on continuation lines. Handle narrow columns and negative indentation, and add regression coverage. Fixes GothenburgBitFactory#3914
libfaketime 0.9.13 rejects the s suffix in relative offsets. Seconds are already the default unit, so use +5 and +1 to keep these tests compatible with both older and newer versions.
2d3cb5a to
16c2f49
Compare
djmitche
left a comment
djmitche
left a comment
There was a problem hiding this comment.
Looks good -- thanks!
Please remove the Changelog diff, and one additional question below.
| def test_export_end(self): | ||
| self.t("1 start") | ||
| self.t.faketime("+5s") | ||
| self.t.faketime("+5") |
There was a problem hiding this comment.
What was the motivation for this change?
There was a problem hiding this comment.
When CI ran, i get these errors from faketime on arch:
https://github.com/GothenburgBitFactory/taskwarrior/actions/runs/34319293173/job/102363309252#step:4:190
https://github.com/GothenburgBitFactory/taskwarrior/actions/runs/34319293173/job/102363309252#step:4:315
I'm not SUPER familiar with libfaketime. I saw this in the docs https://github.com/wolfcw/libfaketime/blob/v0.9.13/README#L348 and it doesn't say anything about an "s" modifier. So.. not entirely sure if it was removed or what, but this did get it passing with the newer build.
There was a problem hiding this comment.
Huh, I wonder if we're using a "floating" version of that library. Anyway, thanks for the details!
Leave the release changelog to be generated from Git history.
2 participants
Wrap each annotation separately and retain its indentation on continuation lines. Handle narrow columns and negative indentation, and add regression coverage.
Fixes #3914
Before
After