Fix Lands 8 team identity integration - #20
Open
GerwinVerkerk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Lands hook still compiles against LandsAPI 6.44.6 and calls
Land#getId(). Lands 8 removed that numeric ID API, so the hook can load but throwsNoSuchMethodErroronce team identity is evaluated during an active KoTH.Solution
Using reflection to retain the removed numeric ID was considered, but rejected because it keeps the hook coupled to an obsolete implementation detail and cannot provide a stable Lands 8 contract.
Verification
./gradlew --no-daemon :Hooks:Team-Lands:test— passed, 4 tests, 0 failures/skips./gradlew --no-daemon build— passed on Java 25git diff --check— passedImpact and risk
Rollback
Revert this commit and restore the prior Lands API dependency. That rollback only supports pre-Lands-8 runtimes because the previous numeric ID call does not exist in Lands 8.