Repository navigation
Add --allow-empty to skip intentionally empty keys - #1
Merged
Merged
Conversation
Variables that are intentionally blank, such as SENTRY_DSN= in a local .env, made every check fail with exit 1. The new repeatable option --allow-empty KEY (comma-separated lists and PREFIX* patterns supported) excludes the named keys from the empty-value check only. Missing and extra keys are still reported, and output is unchanged without the option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: intentionally blank variables such as
SENTRY_DSN=fail every check with exit 1.After:
--allow-empty KEY(repeatable, comma-separated,PREFIX*patterns) excludes the named keys from the empty check only. Missing and extra keys are still reported, and there is no output change without the option.How: option parsing and validation in
src/cli.ts(invalid values exit 2 with a clear message), the empty-key filter insrc/compare.ts, a README options row and example (checked against the real output by a test), and new tests intests/cli.test.ts,tests/compare.test.tsandtests/project.test.ts.Tests: 108 pass (91 before). Typecheck, lint and build are clean.
Built with BAKED (bench loop round 03)