Repository navigation
Add --roots to order - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by gulliby
Before.
intsmith order A Nshowed the order and the smallest primitive root, but there was no way to see how many primitive roots N has.After.
order --roots A Nadds one last linerootswith that count (0 when N has no primitive root, otherwise phi(phi(N))). Without the flag the output is unchanged; for a non-unit residue thestatusline stays,rootsfollows it and the exit code stays 1.How.
intsmith/commands/order.pydeclares the--rootsflag and prints the line; five new test cases intests/test_cmd_order.py(four exact outputs, one--roots takes no valueerror); one sentence added to theorderbullet in the README. Usage text andcli.pyare untouched.