Repository navigation
Add --max-count to stop after the first N matches - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by gulliby
Adds
--max-count N(-m N) to stop after the first N matching records, likegrep -m.Before: logslice printed every match and read the input to its end, even when only the first few records were wanted from a very large log.
After: the tool stops reading as soon as N records have matched (after all filters, across files in argument order). Later files are not opened.
--countprints at most N, and--summarysummarizes only those N records.An invalid value (
0,01,-1,abc,1000000000, empty) is an argument error with exit status 2.How:
parse_max_countvalidator insrc/logslice/filters.py, the option and the early stop insrc/logslice/cli.py, README paragraph and options-table row, one new row in the help test, and 34 new cases intests/test_max_count.py(291 tests in all).