Repository navigation
v1.2.3: recognise a Sega CD disc as its own region's release - #14
Merged
Merged
Conversation
The USA and European releases of many Sega CD games share a serial, and when Redump lists only one of them the app took that one whatever the disc: a USA Sonic CD came up as "Sonic CD (Europe)" and got the European picture and box art. The regions in the disc's header (or the .cue name) now decide it, and a disc only Redump's other-region entry matches is named for its own region. Sega's "MK-4407" header serials also match a listed "4407".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The USA and European releases of many Sega CD games share a serial, and when Redump lists only one of them the app took that one whatever the disc: a USA Sonic CD came up as "Sonic CD (Europe)" and got the European picture and box art. The regions in the disc's header (or the .cue name) now decide it, and a disc only Redump's other-region entry matches is named for its own region. Sega's "MK-4407" header serials also match a listed "4407".
What this changes
How it was tested
Checklist
python scripts/hygiene.pyis cleanpython -m unittest discover -s tests -t .passes