Repository navigation
Drop get_fingerprint and set_license from the v5 operation lists - #728
Merged
Merged
Conversation
Neither operation exists in Harper core or Harper Pro at v5.0.0 or any later tag, so the v5 reference should not list them as callable. The deprecated-operations table now says both were removed in v5.0.0, and that install_usage_license, the usage-license operation, is Harper Pro. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes references to the deprecated get_fingerprint and set_license operations from the documentation, including the CLI operations, operations API, and users and roles overview. It also updates the deprecation table to clarify that these operations were removed in v5.0.0. I have no feedback to provide as there are no review comments.
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-728 This preview will update automatically when you push new commits. |
kriszyp
approved these changes
Oct 13, 2026
kriszyp
left a comment
Member
There was a problem hiding this comment.
Love deletion PRs
🤖 Reviewed with Codex
🧹 Preview CleanupThe preview deployment for this PR has been removed. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v5 reference still lists
get_fingerprintandset_licenseas callable (deprecated) operations, but neither exists in Harper core or Harper Pro.git grep -i -e get_fingerprint -e set_licensefinds nothing in either repo atv5.0.0,v5.2.15,v5.3.2(the newest tag in both) or currentmain, outside tests and Markdown, and atv5.3.2harper-pro has no match even counting those. Both were still present on the v4 line (bin/cliOperations.jsatv4.3.0-beta.4).reference/operations-api/operations.md: removes both rows from the Registration & Licensing table, which lists operations you can call. In the "Other Deprecated Operations" table, the two rows now sayRemoved in v5.0.0.set_licensepoints toinstall_usage_licenseand notes that it is Harper Pro (it is in harper-pro'slicensing/usageLicensing.ts; core has no usage-license operations).reference/cli/operations-api-commands.md: removes both rows.reference/users-and-roles/overview.md: removes both rows from the super_user-only Registration table.reference_versioned_docs/(v4) is unchanged, since both operations exist there.Overlap with #722
#722's local branch has unpushed commits that edit two of the same lines. When both are merged, whichever goes second has to resolve two small conflicts:
operations.md, deprecated table: keep this PR's twoRemoved in v5.0.0rows. Documentharper deploy setup=true provider=github-actions, and how a workflow uses a trust policy #722'sget_fingerprintcell ("None:registration_inforeturns only the version") no longer applies once the row says the operation was removed.operations-api-commands.md: keep Documentharper deploy setup=true provider=github-actions, and how a workflow uses a trust policy #722's newregistration_inforow ("Get the Harper version") and drop the two removed rows.The Registration & Licensing table merges cleanly, and #722 doesn't touch
overview.md.Not changed here
The Registration & Licensing table also lists
install_usage_licenseandget_usage_licenseswithout saying they need Harper Pro. Neither exists in core.npm run format:checkis clean andnpm run buildpasses.🤖 Generated with Claude Code