Skip to content

Drop get_fingerprint and set_license from the v5 operation lists - #728

Merged
dawsontoth merged 1 commit into
mainfrom
docs/remove-get-fingerprint-set-license
Oct 13, 2026
Merged

dawsontoth merged 1 commit into
mainfrom
docs/remove-get-fingerprint-set-license

Conversation

@dawsontoth

Copy link
Copy Markdown
Contributor

The v5 reference still lists get_fingerprint and set_license as callable (deprecated) operations, but neither exists in Harper core or Harper Pro. git grep -i -e get_fingerprint -e set_license finds nothing in either repo at v5.0.0, v5.2.15, v5.3.2 (the newest tag in both) or current main, outside tests and Markdown, and at v5.3.2 harper-pro has no match even counting those. Both were still present on the v4 line (bin/cliOperations.js at v4.3.0-beta.4).

  • reference/operations-api/operations.md: removes both rows from the Registration & Licensing table, which lists operations you can call. In the "Other Deprecated Operations" table, the two rows now say Removed in v5.0.0. set_license points to install_usage_license and notes that it is Harper Pro (it is in harper-pro's licensing/usageLicensing.ts; core has no usage-license operations).
  • reference/cli/operations-api-commands.md: removes both rows.
  • reference/users-and-roles/overview.md: removes both rows from the super_user-only Registration table.

reference_versioned_docs/ (v4) is unchanged, since both operations exist there.

Overlap with #722

#722's local branch has unpushed commits that edit two of the same lines. When both are merged, whichever goes second has to resolve two small conflicts:

The Registration & Licensing table merges cleanly, and #722 doesn't touch overview.md.

Not changed here

The Registration & Licensing table also lists install_usage_license and get_usage_licenses without saying they need Harper Pro. Neither exists in core.

npm run format:check is clean and npm run build passes.

🤖 Generated with Claude Code

Neither operation exists in Harper core or Harper Pro at v5.0.0 or any
later tag, so the v5 reference should not list them as callable. The
deprecated-operations table now says both were removed in v5.0.0, and
that install_usage_license, the usage-license operation, is Harper Pro.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dawsontoth
dawsontoth requested a review from a team as a code owner October 12, 2026 20:16

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes references to the deprecated get_fingerprint and set_license operations from the documentation, including the CLI operations, operations API, and users and roles overview. It also updates the deprecation table to clarify that these operations were removed in v5.0.0. I have no feedback to provide as there are no review comments.

@github-actions
github-actions Bot temporarily deployed to pr-728 October 12, 2026 20:20 Inactive
@github-actions

Copy link
Copy Markdown

🚀 Preview Deployment

Your preview deployment is ready!

🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-728

This preview will update automatically when you push new commits.

@kriszyp kriszyp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love deletion PRs

🤖 Reviewed with Codex

@dawsontoth
dawsontoth merged commit fcc9052 into main Oct 13, 2026
13 checks passed
@dawsontoth
dawsontoth deleted the docs/remove-get-fingerprint-set-license branch October 13, 2026 14:51
@github-actions

Copy link
Copy Markdown

🧹 Preview Cleanup

The preview deployment for this PR has been removed.

This branch was previously deployed

1 inactive deployment
pr-728 — 3c687b6b Deployed Oct 12, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants