Repository navigation
fix(deploy): say a staged release is already installed when activating it - #1947
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the descriptive copy for activating and rolling back staged releases in both the UI components and their corresponding tests to make the behavior clearer. The review feedback suggests correcting a minor grammatical issue regarding subject-verb agreement where 'every node, which restart' should be updated to 'every node, which restarts' in two locations.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
…g it The activate confirmation and the staged-release detail said "Nothing is installed" and "with nothing to install", which reads as if activation does nothing. The point is the opposite: the install already happened when the release was staged, so activating it only switches each node over. - Activate dialog: "Everything was installed when this release was staged, so each node just switches to it." - Roll back dialog: "Each node kept this release installed when it was replaced, so it just switches back." - Staged detail: "Staged: built and installed, but not live. Activating it just switches each node to it." Harper's own design notes back each claim: an activation "swaps that artifact in without resolving, fetching or installing anything", and a kept release is "a whole installed tree" (harper components/DESIGN.md). Both dialogs also say the release "goes live on all nodes, which restart one at a time" rather than "every node, which restart", which mixed a singular subject with a plural verb. The tests now pin each sentence, and the "Activate again" variant with its extra restart sentence; reverting the copy turns them red. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dawsontoth
force-pushed
the
fix/staged-release-already-installed
branch
from
October 13, 2026 17:54
20c1026 to
95378e7
Compare
dawsontoth
marked this pull request as ready for review
October 13, 2026 18:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⊙ Problem
The activate dialog said "Nothing is installed", and the staged detail said "with nothing to install". Both read as if activation does nothing. The point is the opposite: staging already did the install, so activating is quick and safe.
🤔 Is a copy-only change the right size, and is the positive framing right?
Yes, as asked. Three sentences change and no behavior does. The new copy says the install already happened instead of "nothing is installed". If the negation reads better, swapping it back is a one-line change. The "Stage only" help text and the already-live "nothing to activate" agree with the new copy, so they stay.
💡 Solution
Harper backs each claim. An activation swaps the staged build in "without resolving, fetching or installing anything", and a kept release is "a whole installed tree" (harper
components/DESIGN.md).Every string, before and after
✅ Verification
stage's copy, all four tests fail.npx vitest run --maxWorkers=40 (533 files, 5,292 passed),npx tsc -b0,npx oxlint --format stylish .0,npx dprint check0. The commit went through the pre-commit hook.🤖 Generated with Claude Code
Related PRs: #1943 overlaps (merged; this rewords the copy it shipped)
Complexity: easy
Review-Coverage: authored=claude; ran=codex,gemini,cursor-composer; adjudicated=domain; declined=cursor-grok,cursor-kimi,cursor-muse,muse; rounds=3; full=1 @ 95378e7
Review-Attention: skim ~1m @ 95378e7