Improve FeatureFramework quality-of-life ergonomics - #4
Draft
remdui wants to merge 6 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repository-wide, compatibility-preserving quality-of-life pass across FeatureFramework. The repository was reviewed repeatedly across API, core, toolkit, theme support, Paper, Velocity, integrations, processor, testkits, examples/docs, acceptance fixtures, build scripts, and CI. The changes intentionally avoid architectural churn and focus on recurring developer friction, safer external input, read-only diagnostics, composability, and small allocation/correctness improvements.
Identifiers and public runtime API
FeatureId.isValid(...)/FeatureId.tryParse(...)ServerId,ThemeId, andThemeItemIdFeatureCatalog.findByName(...)safe for null/malformed external inputFeatureSnapshot.active()/failed()CapabilityRegistry.findCapability(...),requireCapability(...), andhasCapability(...)while retaining reload-safe referencesFeature, resource, and service composition
FeatureCollection.Builder.features(...)andFeatureCollection.size()FeatureResourceExtensionsInternalServiceRegistryFeatureConfigHandler.subscribeReload(...)subscriptions alongside the existing listener APIDependencyCheckResultThemes
Theme.size()andThemeRegistry.size()ThemeRegistry.Builder.include(...)ThemeIteminstances and batches to be reused directly throughTheme.BuilderConfiguration and storage QoL
ConfigMap.putAll(...),size(), andisEmpty()ConfigNodemap/list shape checks,size(), and optional typed readsConfigView.contains(...), optional typed reads, atomicputAll(...), and batchputAll(...)YamlFile.path(), optional load-failure diagnostics, and load-failure stateConfigService.isCached(...), cached file count, and immutable cached-path snapshotsCache, HTTP, token, and text toolkit QoL
FileCacheStoreJsonCacheFile, matchingCacheValueAsyncHttpTransport.postJson(...)MessagePlaceholdersinstance and add contains/size/empty/map/apply conveniencesTokenServiceloaders toCompletionStage, add an infinite-token convenience overload, explicit cleanup/clear, namespace, and empty-state helpersTokenResult.isOk()/payloadOptional()Language.code(), safe case-insensitiveLanguage.fromCode(...), and cache the immutable localizable-language listhasPrevious,hasNext,isFirst,isLast,previousPage,nextPage)DataRegistry and DataProvider ergonomics
playerId()convenience toPlayerReferencePlayerIdentityResolverPlayerReferenceResolverDataProviderResourcesAutoCloseableTestkit
InterfaceProxy.of(Class)and clearer upfront interface validationCompatibility
find(String)next tofind(FeatureId)ServerId.optional(...)and mutableConfigMapcollection viewsTokenService's loader widening remains source/binary compatible at erasure and accepts existingCompletableFuturesuppliersValidation
CI Lint/ Checkstyle / ShellCheck: passedverify: passed