Skip to content

Report failing setup checks in the weekly stuck-users mail - #1596

Merged
helpcodeai merged 9 commits into
mainfrom
fix/setup-check-visibility
Nov 9, 2026
Merged

helpcodeai merged 9 commits into
mainfrom
fix/setup-check-visibility

Conversation

@helpcodeai

Copy link
Copy Markdown
Contributor

What and why

A refused "Check and save" in the guided setup (setup_verify_failed) never becomes a tool call, so the weekly stuck-users report could not see it. On 2026-11-08 a wrong login body in the Éxito adapter (#1584) blocked a customer for a day without a trace in the report; an Odoo probe returning 500 for 8 workspaces was invisible too (#1587).

  • New section 6 "Setup checks that fail" in deploy/cloud/stuck-users-report.sh: per adapter, the workspaces whose check failed in the window and that have not got through since (no verified setup_completed, no successful call on that adapter after the first failure), with the failure kinds and statuses. When the error may be the adapter's (bad_request, not_found, upstream_error, error…) the top 3 error texts and the workspaces are listed, also on free-mail addresses; customer-side kinds (auth_failed, rate_limited, invalid_input, unreachable) are counted. Etsy stays in section 5. The summary/subject gains "N workspaces stuck at a setup check (M possibly the adapter)".
  • scrubProviderMessage keeps 400 characters instead of 160, so the provider's own words survive after our hint (the Odoo Invalid field 'customer_rank' was cut off).

Dry run on Cloud (read-only, --print): 82 of 175 workspaces with a failed check this week not through, 37 with an error that may be ours; it lists the Éxito 400, the Odoo 500, YouTube Data's 400s and others.

Cloud and self-hosted

The report runs on the Cloud droplet only (systemd timer). The longer provider message applies to both modes.

Tests

  • Repository root: bash deploy/cloud/stuck-users-report.test.sh → all checks passed (new section 6 checks: adapter-side failure listed with scrubbed text on free mail, credential failure counted not listed, fixed setups and Etsy not listed, totals in the summary).
  • packages/backend: npx jest src/audit/product-event --maxWorkers=4 → passed; npx tsc --noEmit -p tsconfig.json → clean; eslint on the changed files → clean.

A refused "Check and save" in the guided setup never becomes a tool call, so the weekly report could not see it: a wrong login body in the Éxito adapter blocked a customer for a day without a trace. Section 6 lists, per adapter, the workspaces whose check failed this week and that have not got through since; workspaces whose error may be the adapter's are listed with the error, wrong credentials are counted. The provider message kept in setup_verify_failed grows from 160 to 400 characters, so the provider's own words survive after our hint.
@helpcodeai
helpcodeai enabled auto-merge (squash) November 9, 2026 08:29
@helpcodeai
helpcodeai merged commit 5413298 into main Nov 9, 2026
16 checks passed
@helpcodeai
helpcodeai deleted the fix/setup-check-visibility branch November 9, 2026 11:11
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant