Repository navigation
Read Odoo partners without fields that need the Invoicing app - #1597
Merged
Merged
Conversation
odoo_list_partners is the setup check of both Odoo adapters and asked for customer_rank and supplier_rank. Those fields come with Odoo's Invoicing app: an Odoo without it answered the check with a 500 Invalid field, and the setup page told the customer the problem was on their side. 8 workspaces hit it on Cloud in two weeks. The wrapper now reads only fields every Odoo has; the domain hint says when customer_rank exists.
helpcodeai
enabled auto-merge (squash)
November 9, 2026 09:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
odoo_list_partnersis the setup check (probe) of both Odoo adapters and readcustomer_rankandsupplier_rank. Those fields come with Odoo's Invoicing app: an Odoo without it answers the check with500 ValueError: Invalid field 'customer_rank' on 'res.partner', and the setup page tells the customer it is "on their side, not your configuration". 8 Cloud workspaces hit it in the last 14 days;fields_geton three affected instances confirmed two of them have no rank fields.odooandodoo-jsonrpc: the partner wrapper reads onlyid, name, email, phone, city, country_id, vat.domainhint still shows[["customer_rank",">",0]]and now says that field needs the Invoicing app.Installed connectors keep their stored tool until "Apply update"; a targeted update of unchanged
odoo_list_partnersmappings can follow after deploy.Cloud and self-hosted
Same in both: the adapter JSON is shared.
Tests
packages/backend:npx jest src/adapters/intl/odoo --maxWorkers=4→ passed. Repository root:node scripts/validate-adapters.mjs --warn→ only the existing tool-prefix warnings of odoo-jsonrpc (it shares tool names with odoo by design);node scripts/regenerate-catalog.mjs→ no diff.