Repository navigation
Show a styled sign-in result page in the browser - #261
Merged
Merged
Conversation
The page the loopback listener returns at the end of `hodeishield login` was a bare paragraph. It is now a self-contained page with the product mark, for success, denied access, a failed or mismatched response and unknown paths. It follows the system light or dark preference, loads nothing from the network and runs no script, and a Content-Security-Policy header allows only its stylesheet by hash. The text is in English, Spanish, German or French, following Accept-Language, and nothing from the request is written into it. Closes #257 Signed-off-by: d0ubl3g <48954024+d0ubl3g@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The page the browser shows at the end of
hodeishield loginwas unstyled English text, unlike the consent screen before it.Change
auth/callback_page.rsrenders the success, denied, failed, mismatched-state and not-found pages.Accept-Language(q-values honoured): English, Spanish, German, French, Italian or Basque, with English as the fallback.langattribute and a "you can close this window" line.default-src 'none'with the stylesheet allowed by its hash, plusbase-uri 'none',form-action 'none'andframe-ancestors 'none'.access_deniednow answers400 Bad Requestinstead of200 OK.Tests
langand headline in two languages, and that nothing from the request is reflected.cargo fmt --check,cargo clippy --workspace --all-targets -D warnings,cargo xtask codegen --checkandcargo test --workspacepass (383 tests).