Repository navigation
Reject malformed card metadata and extend core failure coverage - #414
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Malformed milestone metadata could leave
parse_card_filereporting success with partially parsed card identity, links and milestones. Return the original body without parsed metadata when validation fails. Rebuild also now rejects malformed CRLF headers consistently with LF headers, preserving the existing database projection on failure. Both failures were reproduced before the fixes and are covered by regression tests.Continue the core coverage work from #412:
No new dependencies or coverage exclusions are introduced.
Validation
./make.sh coverage: 835/835 tests passed; HTML and JSON reports generated.git diff --checkpassed.Contribution Checklist
Licensing
Code Quality
Security & Dependencies
Documentation