Repository navigation
Reject stale daemon version fallback in Git checkouts - #416
Merged
Merged
Conversation
This was referenced Nov 9, 2026
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If root
VERSIONis missing, a full Git checkout currently accepts a stale generateddaemon/VERSION. That can stamp holderd and holderctl with an old product version instead of failing the build.Reject the fallback when the parent has Git metadata, including a worktree
.gitfile. Standalone source packages still use their prepared local VERSION; unprepared exports now receive an explicit preparation error. Normal checkout builds continue to prefer and track root VERSION.Validation: the regression fails on the original source and passes with this change. It exercises the production CMake version block, root-only rebuilds, stale fallback rejection for checkouts/worktrees, invalid root values and prepared/unprepared exports. All 20 release tests and 41 staging tests pass; version and core/contract boundary checks and diff checks pass. No C++ runtime code changed.
Continues #130 and #122. Android derivation is separately in #413; end-to-end release-artifact validation remains part of the next actual release.