Auth doc rewrite - #191
Open
sdumetz wants to merge 12 commits into
Open
Conversation
Both doc navs now pin below the top navbar (position: sticky) and get a max-height with overflow-y: auto so a nav taller than the viewport scrolls independently, with a thin trackless scrollbar and bottom padding on the list to make the end of scroll unambiguous. The nav-left collapsible drawer mode on narrow screens is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Search engines only saw an empty cross-origin iframe. The include now renders an indexable poster image (the server's square scene-image-* renders, responsive srcset, object-fit: cover) wrapped in a figure with a captioned link to the scene, an optional visible abstract and a per-embed 3DModel JSON-LD block (replacing the hand-written one in the item layout). The iframe is part of the markup, inert (data-src, no src): a small script promotes it on click - or immediately with autoplay=true, used on the homepage showcases - and only reveals the viewer once its load event fires, so the poster survives wherever the cross-origin viewer never loads (search engines, server down). The play button hover uses the theme gold. The server+embed parameters are replaced by a single canonical scene url plus placeholder, autoplay, params, abstract and model options. The title parameter is required and fails the build when missing; the persisted titles were checked against each scene document's own metas[].collection.titles, adopting the richer server values. This also fixes newsletter_04's broken double-path server value. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FG2jt5LjmkNWLThstqLHZ3
…and API doc structure
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // is down, "load" never fires and the poster stays visible | ||
| container.classList.remove("ecorpus-facade"); | ||
| }); | ||
| iframe.setAttribute("src", iframe.getAttribute("data-src")); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #186.