Skip to content

fix: exclude Slack's reserved mention keywords from people extraction #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrissanchez-iops wants to merge 1 commit into from
Closed

fix: exclude Slack's reserved mention keywords from people extraction #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/detectors/knowledge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,11 @@ const CSS_AT_RULES = new Set([
"stylistic", "styleset", "colorprofile", "property",
]);

// Slack's own reserved mention keywords — never a person, in any project's docs
const SLACK_RESERVED_MENTIONS = new Set([
"here", "channel", "everyone", "all", "group",
]);

function extractPeople(content: string): string[] {
const people = new Set<string>();

Expand All @@ -242,6 +247,7 @@ function extractPeople(content: string): string[] {
if (HANDLE_BLACKLIST.has(lower)) continue;
if (JSDOC_TAGS.has(lower)) continue; // @param, @deprecated, etc.
if (CSS_AT_RULES.has(lower)) continue; // @keyframes, @font-face, etc.
if (SLACK_RESERVED_MENTIONS.has(lower)) continue; // @here, @channel, etc.
// Skip npm scope prefixes: @pixi/layout → next char after handle is "/"
const fullMatch = m[0]; // e.g. "@pixi"
const afterIdx = m.index! + fullMatch.length;
Expand Down