Repository navigation
fix: return failure status when time-series loads fail - #279
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A time-series copy can report failed stores and still exit 0, causing AWS Batch to mark the job successful. Raise a ClickException with the original error as its cause instead of printing the error and continuing to the completion message. Existing fatal-service error handling remains intact.
Observed during September 28, 2026 MVP Batch Events testing: a load into dev used an unencrypted internal HTTP CDA_API_ROOT, matched 147 series, and reported three failed stores, but Batch received exit code 0. The HTTP connection-pool warning is addressed separately in cwms-python #312; this companion change fixes the CLI process status.
Validation: 38 related loader and CLI error-handling tests passed on Python 3.14. Regression cases demonstrate that both read and aggregate write failures previously exited 0 and now exit 1 while retaining the failure text. Successful, empty-data, and dry-run commands still exit 0. Black, isort, and git diff --check passed. No patched Batch run or live CDA writes were performed; the dev container was unavailable locally.