Add applicant determination access setting - #4976
Conversation
|
A new Hypha implementor needs this function. With the default value nothing will change for current installs. |
frjo
added
Type: Enhancement
wes-otf
left a comment
wes-otf
left a comment
There was a problem hiding this comment.
It looks pretty good to me! Left a super small comment and also wondering if there's a way to indicate to staff what fields the applicants will see - while it seems intuitive in wagtail I could see staff accidentally writing something in the required Message field that applicants weren't supposed to see if it wasn't labeled correctly.
Open to thoughts on that though!
| {% if answer == True or answer == False %} | ||
| {{ answer|yesno:_("Agree,Disagree") }} | ||
| {% for question, answer in group.questions %} | ||
| <h3 class="pb-1 mb-2 font-medium border-b text-h3 border-base-300 question">{{ question }}</h3> |
There was a problem hiding this comment.
super nitpick & I don't think it was introduced in this PR but should we add a little more space between detailed_data questions? maybe even to match the gap-8 of the other section separators? seems a little scrunched together
There was a problem hiding this comment.
This looks perfect! I was also thinking maybe a divider on the form itself so staff knew before submitting what fields would be seen. Let me know if you think that makes sense too? outside of that this is ready to go!
This never occurred to me but reading your comment and it such an obvious feature. |
…rgs to hide determination details from applicants.
ca5d6a2 to
64f0265
Compare
2 participants
Adds a new setting
DETERMINATION_DETAILS_ACCESS_APPLICANTthat default to True. So no change in behaviour unless the setting is changed from the default.Setting it to False will hide
detailed_datafrom applicants.Also fixed a view permission bug in ApplicantDeterminationDetailView.