Repository navigation
fix(discovery): declare the reachable browser II origin - #151
Open
humandebri wants to merge 1 commit into
Open
humandebri wants to merge 1 commit into
humandebri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
本番の
ic0.appはclient_domain_canister_mismatchを返すため、ICP MCP のopen_appが代替 origin の許可リストを取得できませんでした。発見用の宣言をブラウザ設定と同じ到達可能なicp0.ioに合わせます。既存 Private MCP の seed origin と ACL は変更しません。検証: 変更前は本番・staging × 両ドメインの4件でテスト失敗。修正後は Worker 全テスト・契約チェック・型チェック・ビルドと GitHub CI が成功（iOS は対象外）。本番 Worker 配備済みで、両ドメインの open_app・Candid・説明取得が成功しています。
ユーザーの再接続後、icp0.io と ic0.app の principal 一致、既存 DB 一覧・ページ取得、専用 fixture の作成・etag 付き編集、競合拒否、一括更新失敗時のロールバック、匿名 read/write の権限拒否を ICP plugin で確認。fixture は etag 付きで削除し、消失確認済み。ブラウザ画面の principal との直接比較、Questions-only grant は未検証。既存 Kinic Wiki plugin は別 OAuth 接続の再認証が必要なため、今回の同時比較は未実施です。