Repository navigation
Conversation
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Reviewer's GuideConfigurationInstall uv with setup-uv before cibuildwheel and remove its uv extra so riscv64 uses the prebuilt binary instead of compiling uv from source.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. The workflow now runs a pinned external action to install uv before building release wheels. If it produces incorrect wheels that are then published, reverting the workflow cannot recall artifacts already distributed to users; they would need to be yanked or superseded with a corrected release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the slow build time due to compilation of uv discussed in #182.
I've tested this on my fork and the riscv64 build finished in ~36m, although the memory leak test for 3.14 seems to be having issues.
Summary by Sourcery
Use a prebuilt uv in the PyPI deployment workflow to reduce wheel build times on riscv64.
Bug Fixes:
Enhancements:
CI: