Skip to content

Return None for valueless kvitems members in the yajl2_c builder - #204

Open
nabeel-dev21 wants to merge 1 commit into
ICRAR:masterfrom
nabeel-dev21:kvitems-valueless-member
Open

nabeel-dev21 wants to merge 1 commit into
ICRAR:masterfrom
nabeel-dev21:kvitems-valueless-member

Conversation

@nabeel-dev21

@nabeel-dev21 nabeel-dev21 commented Nov 19, 2026 •

Copy link
Copy Markdown

NULL dereference in yajl2_c builder_value() for valueless kvitems members

When kvitems() is given an event iterable in which a member's map_key is not followed by a value, kvitems_basecoro_send_impl() calls builder_value() on the next key or end_map while builder->value is still NULL, and Py_INCREF(NULL) crashes the interpreter. Filtering a path out of parse() output is enough: with {"name": "x", "password": "secret", "id": 1} and the password events dropped, kvitems(events, '') segfaults on yajl2_c while the python backend yields ('password', None) because ObjectBuilder.value starts as None, which builder_value() now matches.

Summary by Sourcery

Handle valueless kvitems() members safely in the yajl2_c backend and return None for their values.

Bug Fixes:

  • Prevent the yajl2_c backend from crashing when kvitems() receives a map member without value events, returning None consistently with the python backend.

Tests:

  • Add coverage for filtered parse events that leave a kvitems() member without a value.

@sourcery-ai

sourcery-ai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Implementation

Make builder_value() return None when no value has been built, matching ObjectBuilder.value and preventing a NULL dereference for valueless members.

  • src/ijson/backends/ext/_yajl2/builder.h L94-95, L100-102

Documentation

Document that kvitems() in the yajl2_c backend yields None for members with no value.

  • CHANGELOG.md L32-34

Tests

Cover filtered parse events that leave a member without a value and verify kvitems() yields None for it.

  • tests/test_kvitems.py L85-97

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant