Repository navigation
fix: parse single-quoted CFF author fields - #77
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
beanbean9339
requested review from
NetZissou
and
a balanced review from Copilot
October 12, 2026 15:21
There was a problem hiding this comment.
🟢 Approval recommended
The focused implementation correctly covers both author parsing paths with regression tests.
0 open findings
What changed in this PR
Updates CFF author parsing to remove matching single- or double-quote wrappers.
Changes:
- Reuses
stripWrappingQuotesfor author fields. - Adds regression coverage for single-quoted names and ORCID values.
| File | Description |
|---|---|
src/services/githubImporter.js |
Normalizes quoted author values. |
tests/services/githubImporter.test.js |
Tests single-quoted author parsing. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
NetZissou
approved these changes
Oct 12, 2026
NetZissou
left a comment
NetZissou
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Thumbs up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CITATION.cff.Closes #76
Validation: direct parser check and JavaScript syntax checks pass. Full test suite not run locally (workspace Node.js is v16; CI is configured for Node.js 24).