[GLPI 11] Resources: notification itemtype migration, Directory error and new Email/notification tags

[Samirsncf]

Hello,

After migrating to GLPI 11 and testing the Resources plugin, I noticed several points that may be useful to report.

Overall, the plugin works well and the latest version brings some welcome improvements, but I encountered one notification issue, one issue with the Directory feature, and I also have a few suggestions that could make the plugin even more useful.

1. Resource notification recipients were not available

For notifications related to Resources, the recipient list was no longer displayed in the notification configuration.

I found that the itemtype stored in the glpi_notifications table was still using the old value:

PluginResourcesResource

while GLPI 11 now expects the namespaced class:

GlpiPlugin\Resources\Resource

I fixed the existing notifications with the following SQL query:

UPDATE glpi_notifications
SET itemtype = CONCAT(
    'GlpiPlugin',
    CHAR(92),
    'Resources',
    CHAR(92),
    'Resource'
)
WHERE itemtype = 'PluginResourcesResource';

SELECT ROW_COUNT() AS notifications_corrigees;

SELECT id, name, itemtype
FROM glpi_notifications
WHERE id BETWEEN 84 AND 104
ORDER BY id;

After this change, the Resources notification recipients were available again.

It may be useful to include this conversion automatically during the plugin upgrade/migration process.

2. "Service" field in email notifications

A very welcome improvement in the latest version is that the Service field can now finally be used correctly in notification emails.

The corresponding notification tag did not work properly in the previous version.

This is very useful for HR/resource notification templates.

3. Directory feature returns an error

The Directory feature currently generates an error when trying to use the search/filter function.

The interface only displays:

An error has occurred

I temporarily disabled/hidden the Directory feature for the affected user profiles while waiting for a fix.

4. Suggestion: add an Email field

The Resources form currently contains fields such as:

Phone
Mobile phone

Several users have asked me to also have an Email field directly in the Resource information.

I think the best option would be to keep both existing phone fields and simply add a dedicated Email field.

This would be particularly useful when the Resource object is used for HR processes and when information is sent through notifications.

5. Suggestion: additional notification tags

It would also be very useful to expose additional notification tags for Resources, especially:

Employee ID / Matricule
Email

For example, having notification tags equivalent to:

##resource.employeeid##

and

##resource.email##

would allow these values to be used directly inside email notification templates.

The exact tag names can of course follow the plugin's existing naming convention.

Summary

The main points are therefore:

Existing Resource notifications may still use the old PluginResourcesResource itemtype after migration.
Updating it to GlpiPlugin\Resources\Resource restores the notification recipients.
The Service notification field/tag now works correctly, which is a great improvement.
The Directory search currently produces an error.
Adding an Email field to Resources would be useful.
Adding notification tags for Employee ID / Matricule and Email would make notification templates much more flexible.

Thank you for maintaining and improving the plugin.

These additions would make the Resources plugin even more useful for HR workflows on GLPI 11.

[Samirsncf]

I also noticed that the Resource form layout was clearer and better organized in version 3 of the plugin.

In the previous version, the form had more spacing between the different sections, which made it easier to read and use.

In particular, some fields related to the resource departure and workflow were displayed in a separate section below the Description field, such as:

• Request date
• Can be associated with a ticket
• Send notification
• Declared as leaving
• Departure date

This made the form visually easier to understand and clearly separated the main Resource information from the departure/workflow information.

In the current version, these fields are integrated directly into the main form, which makes the interface feel much more crowded and dense.

It would be great to restore a layout closer to version 3, with more spacing and a dedicated section below the Description field for departure and workflow-related information.

The previous layout was, in my opinion, more readable and user-friendly.

[Samirsncf]

Additional findings after further testing on Resources 4.1.2 / GLPI 11.

6. Automatic notification on "Declare an arrival" does not send the email

I found another issue with the option:

Send an automatic notification at the end of the "Declare an arrival" form

Current behaviour

• If the option is No, the checkbox Send a notification is displayed.
• If I manually check this box, the New Resource notification is sent correctly.
• If the option is Yes, the checkbox disappears as expected, but no notification is sent.

After checking the plugin code, the issue seems to come from the fact that when automatic notification is enabled, use_notification becomes 0, so the whole send_notification field is not rendered anymore.

However, the resource creation logic only triggers the notification when:

isset($this->input['send_notification'])
&& $this->input['send_notification'] == 1

So when automatic mode is enabled, send_notification is never posted and the new event is not raised.

Workaround tested successfully

In:

templates/wizard_secondstep_resource.html.twig

I changed the notification block so that when automatic notification is enabled, a hidden field is still sent:

{% if params['use_notification'] is defined %}
    {% if params['use_notification'] == 1 %}
        {% if get_current_interface() == 'central' %}
            {{ fields.checkboxField(
                'send_notification',
                options['send_notification'],
                __('Send a notification'),
                {
                    'required': mandatory.send_notification is defined,
                    'readonly': readonly.send_notification is defined,
                }
            ) }}
        {% else %}
            {{ inputs.hidden('send_notification', 1) }}
        {% endif %}
    {% else %}
        {{ inputs.hidden('send_notification', 1) }}
    {% endif %}
{% endif %}

With this change:

Automatic notification = No → checkbox remains available.
Automatic notification = Yes → checkbox is hidden, but send_notification=1 is still submitted.
The New Resource email is then sent correctly.

This workaround has been tested successfully on our test environment.

7. Resource history from GLPI 10 is no longer displayed after migration

I also noticed that the History tab only showed entries created since the GLPI 11 / Resources upgrade.

The old history was not deleted: it was still present in glpi_logs, but with the legacy itemtype:

PluginResourcesResource

while new history entries use:

GlpiPlugin\Resources\Resource

For example, in our database we had:

PluginResourcesResource 12879
GlpiPlugin\Resources\Resource 11

Updating the old log entries restored the complete history:

UPDATE glpi_logs
SET itemtype = CONCAT(
    'GlpiPlugin',
    CHAR(92),
    'Resources',
    CHAR(92),
    'Resource'
)
WHERE itemtype = 'PluginResourcesResource';

After this change, the previous Resource history is visible again in GLPI 11.

It may be useful to include the migration of glpi_logs.itemtype automatically during the plugin upgrade, in the same way as other legacy itemtype migrations.